Add NSG monitoring for preconfiguredNSG #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwnt
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
|
Please rebase pull request. |
niontive
reviewed
Sep 7, 2023
gouthamMN
reviewed
Sep 7, 2023
niontive
reviewed
Sep 7, 2023
niontive
reviewed
Sep 7, 2023
niontive
reviewed
Sep 7, 2023
nwnt
force-pushed
the
nsg-monitoring
branch
4 times, most recently
from
aceb852
to
2a6a52b
Compare
kimorris27
previously approved these changes
Oct 24, 2023
nwnt
added
next-release
kimorris27
previously approved these changes
Oct 25, 2023
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
cadenmarchese
approved these changes
Oct 26, 2023
kimorris27
approved these changes
Oct 26, 2023
petrkotas
approved these changes
Oct 27, 2023
| c.Monitor(ctx) | ||
| monitors = append(monitors, c) | ||
| allJobsDone := make(chan bool) | ||
| go execute(ctx, allJobsDone, &wg, monitors) |
There was a problem hiding this comment.
So we essentially introduce concurent mechanism to run multiple monitors.
We might as well migrate the rest to use this pattern, because sequential run we have in the original code is error prone.
petrkotas
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: ARO-3391
What this PR does / why we need it:
Adding monitoring for NSG and emitting metrics when invalid NSG configurations have been detected, including when the FP (the one performing the monitoring) loses access to the NSG.
Test plan for issue:
How did you test that this PR works?
Is there any documentation that needs to be updated for this PR?
N/A